Use reusable frontend workflow from armada - #2695
Merged
Merged
Conversation
aeshub
marked this pull request as draft
May 5, 2026 08:08
aeshub
force-pushed
the
use-reusable-frontend-workflow
branch
from
May 6, 2026 07:42
01445be to
3ca3ef9
Compare
aeshub
marked this pull request as ready for review
May 6, 2026 07:44
aeshub
added
improvement
aeshub
force-pushed
the
use-reusable-frontend-workflow
branch
5 times, most recently
from
May 6, 2026 08:13
a364c24 to
ea8d6ca
Compare
4 tasks
aeshub
force-pushed
the
use-reusable-frontend-workflow
branch
2 times, most recently
from
May 6, 2026 08:37
76fe800 to
55fde5b
Compare
Replace the inline frontend_lint_and_test.yml workflow with a caller to the new reusable lint_frontend_package.yml in armada. Align npm scripts (start->dev, serve->preview, add lint), add react-hooks and react-refresh eslint plugins, align eslint config with pointilla_maps, and update all references in docs and Makefile. Rename fetchImageData/fetchAnalysisData/fetchValueData to use the 'use' prefix (useImageData/useAnalysisData/useValueData) since they are custom hooks calling useQuery. React Compiler rules from react-hooks v7 are disabled for now, to be addressed in a follow-up (see equinor#2698).
aeshub
force-pushed
the
use-reusable-frontend-workflow
branch
from
May 8, 2026 14:06
55fde5b to
eb4c758
Compare
nicholasdalhaug
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the inline
frontend_lint_and_test.ymlworkflow with a caller to the new reusable workflow inequinor/armada(merged in armada#48). All existing checks are preserved (prettier, eslint, build, test, ts-unused-exports).Changes
lint,prettier_check,build,test)eslint-plugin-reactandeslint-plugin-react-refreshto eslint configeslint-plugin-react-hooksto v6 to avoid React Compiler rules (upgrade tracked in Enable React Compiler eslint rules and fix violations #2698)rules-of-hooksviolations inInspectionsContext.tsxreactHooks.configs.recommended.rulesspread (no-op with v6 array-based config)frontend/out/to.gitignoreREADME.md,best_practices.md) to usenpm run devinstead ofnpm startRelated: equinor/pointilla_maps#34